Add -fPIC to the static library#1108
Open
jmcarcell wants to merge 1 commit intoCyan4973:devfrom
Open
Conversation
This is already done for the dynamic library but not for the static one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is already done for the dynamic library but not for the static one. Currently, building ROOT (https://github.com/root-project/root) when using the static library fails with:
I left the Windows check since that is how it is done for the dynamic library.
Alternatively we could change CFLAGS, but given that it is already there for the dynamic library I made this PR.