use Array.from to expand array splats#965
Merged
rhendric merged 1 commit intogkz:masterfrom May 22, 2017
Merged
Conversation
Prior to this commit, [].slice was used to turn array-like things into arrays when needed for splats in array literals. This commit uses Array.from instead, when available at runtime, and falls back to slice when not. This allows a wider range of iterables to be used as splats, on the platforms that support them (platforms missing Array.from will also be missing more exotic iterables). Fix gkz#963.
gkz
reviewed
May 16, 2017
| } | ||
| }''' | ||
|
|
||
| array-from: 'Array.from || function(x){return slice$.call(x);}' |
Owner
There was a problem hiding this comment.
Can the second part of "or" just be slice$.call? Or is there a reason for the wrapping function
Collaborator
Author
There was a problem hiding this comment.
I did try that, but Function.prototype.call needs something to bind it to slice$ or it forgets where it came from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, [].slice was used to turn array-like things into
arrays when needed for splats in array literals. This commit uses
Array.from instead, when available at runtime, and falls back to slice
when not. This allows a wider range of iterables to be used as splats,
on the platforms that support them (platforms missing Array.from will
also be missing more exotic iterables).
Fix #963.
As a relatively simple bug fix, I'm setting the comment period for this at one week, after which I will merge on May 22 if nobody has any concerns.